Skip to content

Allow user to force codspeed root dir value and to install google_benchmark as a system lib #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

Allow user to force codspeed root dir value and to install google_benchmark as a system lib #10

merged 2 commits into from
May 28, 2025

Conversation

GuillaumeLagrange
Copy link
Contributor

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 28, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10 will not alter performance

Comparing allow-codspeed-intallation (308c879) with main (5324618)

Summary

✅ 42 untouched benchmarks

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 28, 2025 •
edited
Loading

CodSpeed Walltime Performance Report

Merging #10 will degrade performances by 33.33%

Comparing allow-codspeed-intallation (308c879) with main (5324618)

Summary

⚡ 3 improvements
❌ 4 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ BarTest[MyFixture] < 1 ns < 1 ns +20%
❌ DoubleTest[MyTemplatedFixture, double] < 1 ns < 1 ns -20%
❌ IntTest[MyTemplatedFixture, int] < 1 ns < 1 ns -16.67%
⚡ BM_Capture[int_string_test] < 1 ns < 1 ns +50%
❌ BM_Capture[int_test] < 1 ns < 1 ns -33.33%
⚡ BM_rand_vector < 1 ns < 1 ns +25%
❌ BM_Template1_Capture[int_string_test] < 1 ns < 1 ns -16.67%

@GuillaumeLagrange GuillaumeLagrange requested a review from art049 May 28, 2025 14:11
@GuillaumeLagrange GuillaumeLagrange changed the title Allow user to force codspeed root dir value Allow user to force codspeed root dir value and to install google_benchmark as a system lib May 28, 2025
art049
art049 approved these changes May 28, 2025
View reviewed changes
core/CMakeLists.txt Outdated
# If there's also a library to install:
install(
TARGETS
codspeed # whatever the target name is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment necessary? not sure to understand

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups, that's a claude leftover sorry 🤓

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or go to jail

@GuillaumeLagrange GuillaumeLagrange force-pushed the allow-codspeed-intallation branch from 2607a21 to 308c879 Compare May 28, 2025 15:09
@GuillaumeLagrange GuillaumeLagrange merged commit 308c879 into main May 28, 2025
8 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the allow-codspeed-intallation branch May 28, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@art049 art049 art049 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeLagrange @art049